Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] add ksize selectors back into sourmash sig functions #1105

Merged
merged 9 commits into from
Jul 17, 2020
Merged

[MRG] add ksize selectors back into sourmash sig functions #1105

merged 9 commits into from
Jul 17, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 16, 2020 •
edited
Loading

Add -k back into sourmash sig functions.

Fixes #1104

TODO: add tests for

  • merge
  • intersect
  • subtract
  • rename
  • extract
  • filter
  • flatten
  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title add ksize selectors back into sourmash sig functions [WIP] add ksize selectors back into sourmash sig functions Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #1105 into master will increase coverage by 9.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   83.86%   92.90%   +9.04%     
==========================================
  Files          98       74      -24     
  Lines        9108     5736    -3372     
==========================================
- Hits         7638     5329    -2309     
+ Misses       1470      407    -1063
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/sig/__main__.py 93.40% <100.00%> (+0.14%) ⬆️
sourmash/signature.py 92.85% <0.00%> (-0.27%) ⬇️
sourmash/_minhash.py 94.82% <0.00%> (-0.26%) ⬇️
sourmash/command_compute.py 97.44% <0.00%> (-0.20%) ⬇️
sourmash/sbtmh.py 89.71% <0.00%> (-0.19%) ⬇️
sourmash/nodegraph.py 93.57% <0.00%> (-0.18%) ⬇️
sourmash/sbt_storage.py 92.00% <0.00%> (-0.12%) ⬇️
sourmash/index.py 97.61% <0.00%> (-0.09%) ⬇️
sourmash/sbt.py 88.79% <0.00%> (-0.07%) ⬇️
sourmash/lca/lca_db.py 97.17% <0.00%> (-0.05%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0fff2...dfa110d. Read the comment docs.

@ctb ctb changed the title [WIP] add ksize selectors back into sourmash sig functions [MRG] add ksize selectors back into sourmash sig functions Jul 17, 2020
@ctb
Copy link
Contributor Author

ctb commented Jul 17, 2020

Ready for review and merge! @erikyoung85 can you take a look at this? :)

erikyoung85
erikyoung85 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@erikyoung85 erikyoung85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

erikyoung85
erikyoung85 reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@erikyoung85 erikyoung85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there seems to be an issue with building sourmash

@ctb
Copy link
Contributor Author

ctb commented Jul 17, 2020

ooh yes, a test failed on the Travis CI build! will fix.

@ctb ctb merged commit 21dc514 into master Jul 17, 2020
@ctb ctb deleted the fix/ksize_selectors branch July 17, 2020 23:06
@ctb ctb mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikyoung85 erikyoung85 erikyoung85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ksize selectors accidentally removed from (many) sourmash sig commands
2 participants
@ctb @erikyoung85